Skip to content

Fixes GH-16475: zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly #16476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fixes GH-16475: zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly #16476

merged 1 commit into from
Oct 17, 2024

Conversation

KaseyJenkins
Copy link
Contributor

@KaseyJenkins KaseyJenkins commented Oct 17, 2024 •
edited
Loading

Added the extern "C" modifier to make zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly.

@KaseyJenkins KaseyJenkins requested a review from dstogov as a code owner October 17, 2024 08:34
@KaseyJenkins KaseyJenkins changed the title Making zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes #16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins KaseyJenkins changed the title Fixes #16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes 16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins KaseyJenkins changed the title Fixes 16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes GH-16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins KaseyJenkins changed the title Fixes GH-16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes #16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins KaseyJenkins mentioned this pull request Oct 17, 2024
Closed
@KaseyJenkins KaseyJenkins changed the title Fixes #16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes https://github.com/php/php-src/issues/16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins KaseyJenkins changed the title Fixes https://github.com/php/php-src/issues/16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes #16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins
Copy link
Contributor Author

Could you please advise of how best to add this to PHP 8.4, so that it would end up in PHP 8.4 GA if possible.

Thanks.

@KaseyJenkins KaseyJenkins changed the title Fixes #16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes GH-16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
@KaseyJenkins KaseyJenkins changed the title Fixes GH-16475 zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Fixes GH-16475: zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly Oct 17, 2024
dstogov
dstogov reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for master.
I also don't see a big problem for PHP-8.4, but I'm not sure about the older branches.

@KaseyJenkins
Copy link
Contributor Author

Thank you @dstogov !
Should I create respective PRs as well(to PHP-8.4 and master)?

@dstogov
Copy link
Member

dstogov commented Oct 17, 2024

Should I create respective PRs as well(to PHP-8.4 and master)?

No, this is not necessary. If you don't care about PHP-8.2 and PHP-8.3 you may re-target this PR to PHP-8.4 (this should be possible through github) and I'll approve it. Otherwise let wait for other opinions.

@KaseyJenkins KaseyJenkins changed the base branch from PHP-8.2 to PHP-8.4 October 17, 2024 09:08
@KaseyJenkins
Copy link
Contributor Author

Thank you @dstogov !
Re-targeted it to PHP-8.4 :)

@cmb69 cmb69 linked an issue Oct 17, 2024 that may be closed by this pull request
zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc Not C++ Friendly #16475
Closed
@dstogov dstogov merged commit cf3ecff into php:PHP-8.4 Oct 17, 2024
8 checks passed
dstogov added a commit that referenced this pull request Oct 17, 2024
@dstogov
Merge branch 'PHP-8.4'
95dbc33 
* PHP-8.4:
  Making zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc C++ friendly (#16476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

Assignees
No one assigned
Labels
ABI break Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zend_hash_str_find_ptr_lc && zend_hash_find_ptr_lc Not C++ Friendly
2 participants
@KaseyJenkins @dstogov